lkml.org 
[lkml]   [2014]   [Nov]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v2 2/3] x86_64,vsyscall: Rewrite comment and clean up headers in vsyscall code
On Mon, Nov 3, 2014 at 12:41 PM, Thomas Gleixner <tglx@linutronix.de> wrote:
> On Mon, 3 Nov 2014, Andy Lutomirski wrote:
>> On Mon, Nov 3, 2014 at 12:31 PM, Thomas Gleixner <tglx@linutronix.de> wrote:
>> > On Wed, 29 Oct 2014, Andy Lutomirski wrote:
>> >
>> >> vsyscall_64.c is just vsyscall emulation. Tidy it up accordingly.
>> >>
>> >> If my comment editing offends anyone, let me know and I can fix it.
>> >>
>> >> Reviewed-by: Josh Triplett <josh@joshtriplett.org>
>> >> Signed-off-by: Andy Lutomirski <luto@amacapital.net>
>> >> ---
>> >> arch/x86/kernel/vsyscall_64.c | 51 +++++++++++++++----------------------------
>> >> 1 file changed, 18 insertions(+), 33 deletions(-)
>> >>
>> >> diff --git a/arch/x86/kernel/vsyscall_64.c b/arch/x86/kernel/vsyscall_64.c
>> >> index 2d912629c96e..ee622f8183f3 100644
>> >> --- a/arch/x86/kernel/vsyscall_64.c
>> >> +++ b/arch/x86/kernel/vsyscall_64.c
>> >> @@ -1,52 +1,37 @@
>> >> /*
>> >> - * Copyright (C) 2001 Andrea Arcangeli <andrea@suse.de> SuSE
>> >> - * Copyright 2003 Andi Kleen, SuSE Labs.
>> >> + * Mostly copyright (c) 2012-2014 Andy Lutomirski <luto@amacapital.net>
>> >
>> > We usualy leave the old copyright notices around even if the code
>> > which is related to them has been removed more or less completely.
>> >
>> > So I change this to:
>> >
>> > /*
>> > * Copyright (c) 2012-2014 Andy Lutomirski <luto@amacapital.net>
>> > *
>> > * Based on the original implementation:
>> > * Copyright (C) 2001 Andrea Arcangeli <andrea@suse.de> SuSE
>> > * Copyright 2003 Andi Kleen, SuSE Labs.
>> >
>> > and apply the whole lot.
>>
>> Would it make more sense to move those copyright notices to
>> arch/x86/vdso/vma.c? That's where most of the code ended up.
>
> That has already a notice from Andi and I cant figure out what parts
> of that have been written by Andrea. We'll worry about that when we
> remove vsyscall_64.c. Until then the git history will be our friend.

Works for me.

--Andy


\
 
 \ /
  Last update: 2014-11-03 22:01    [W:0.031 / U:0.120 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site