Messages in this thread | | | Date | Mon, 3 Nov 2014 19:00:47 +0100 | From | Borislav Petkov <> | Subject | Re: [PATCH 2/2] x86, mce, amd: extend mce-inject for support threshold interrupt event injection on AMD platform |
| |
On Mon, Nov 03, 2014 at 11:51:47AM -0600, Aravind Gopalakrishnan wrote: > On 11/3/2014 11:05 AM, Aravind Gopalakrishnan wrote: > > > >There are three ways that have been used to report machine check event. > >And they are MCE, CMCI/Threshold Interrupt, and POLL. On the Intel > >platform, CMCI/Threshold Interrupt and POLL share the same event handler > >- machine_check_poll(). However, on the AMD platform, they have a > >separate event handler. amd_threshold_interrupt() is used for handling > >Threshold Interrupt event. And machine_check_poll() has been used for > >polling other events. > > > >This patch introduces a new flag MCJ_INTERRUPT that will be used to > >separate CMCI/Threshold Interrupt and POLL handler in mce-inject. > > > >Signed-off-by: Chen Yucong <slaoub@gmail.com <mailto:slaoub@gmail.com>> > >--- > > arch/x86/include/asm/mce.h | 5 +++-- > > arch/x86/kernel/cpu/mcheck/mce-inject.c | 16 ++++++++++++++++ > > arch/x86/kernel/cpu/mcheck/threshold.c | 1 + > > 3 files changed, 20 insertions(+), 2 deletions(-) > > > > > We currently test decoding logic on AMD by performing mce injections using > edac/mce_amd_inj.c, > So instead of modifying mce-inject just for testing > amd_threshold_interrupt(), > Why not put it under mce_amd_inj? (It's AMD specific code anyway)
Right, I think this is supposed to be vendor-agnostic as it is calling mce_threshold_vector() directly.
Btw, I wouldn't mind if someone would sit down and unify those injection methods and come up with a saner interface which can actually be used by humans, not those yucky files you feed mce-inject with...
-- Regards/Gruss, Boris.
Sent from a fat crate under my desk. Formatting is fine. --
| |