Messages in this thread Patch in this message | | | From | Michal Nazarewicz <> | Subject | [PATCH] mm: alloc_contig_range: demote pages busy message from warn to info | Date | Mon, 3 Nov 2014 17:57:53 +0100 |
| |
Having test_pages_isolated failure message as a warning confuses users into thinking that it is more serious than it really is. In reality, if called via CMA, allocation will be retried so a single test_pages_isolated failure does not prevent allocation from succeeding.
Demote the warning message to an info message and reformat it such that the text “failed” does not appear and instead a less worrying “PFNS busy” is used.
Signed-off-by: Michal Nazarewicz <mina86@mina86.com> --- mm/page_alloc.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/mm/page_alloc.c b/mm/page_alloc.c index 372e3f3..e2731eb 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -6431,13 +6431,12 @@ int alloc_contig_range(unsigned long start, unsigned long end, /* Make sure the range is really isolated. */ if (test_pages_isolated(outer_start, end, false)) { - pr_warn("alloc_contig_range test_pages_isolated(%lx, %lx) failed\n", - outer_start, end); + pr_info("%s: [%lx, %lx) PFNs busy\n", + __func__, outer_start, end); ret = -EBUSY; goto done; } - /* Grab isolated pages from freelists. */ outer_end = isolate_freepages_range(&cc, outer_start, end); if (!outer_end) { -- 2.1.0.rc2.206.gedb03e5 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |