lkml.org 
[lkml]   [2014]   [Nov]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] mfd: db8500-prcmu: Provide sane error path values
On Mon, 03 Nov 2014, Fabio Estevam wrote:

> On Mon, Nov 3, 2014 at 2:15 PM, Lee Jones <lee.jones@linaro.org> wrote:
>
> > /* Clean up the mailbox interrupts after pre-kernel code. */
> > @@ -3179,15 +3179,14 @@ static int db8500_prcmu_probe(struct platform_device *pdev)
> > irq = platform_get_irq(pdev, 0);
> > if (irq <= 0) {
>
> Shouldn't this be if (irq < 0) then?

Perhaps Linus can answer that.

Linus,

Is 0 a valid IRQ on the u8500 platform or not?

> > dev_err(&pdev->dev, "no prcmu irq provided\n");
> > - return -ENOENT;
> > + return irq;

--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2014-11-03 18:01    [W:0.107 / U:0.048 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site