Messages in this thread | | | Date | Mon, 3 Nov 2014 19:28:02 +0300 | From | Dan Carpenter <> | Subject | Re: s390/net: Deletion of unnecessary checks before two function calls |
| |
On Mon, Nov 03, 2014 at 05:10:35PM +0100, SF Markus Elfring wrote: > > I agree with your proposed debug_unregister() changes, but not with your > > kfree_fsm() change. > > Why do you want to keep an additional null pointer check before the call > of the kfree_fsm() function within the implementation of the > netiucv_free_netdevice() function?
Think about how long it takes you to figure this out what the bug is and then remember that we have to spend that same amount of time multiplied by the number of patches you have sent.
regards, dan carpenter
| |