lkml.org 
[lkml]   [2014]   [Nov]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: ceph: Deletion of unnecessary checks before two function calls
    > dput() also checks for NULL argument, but the check is wrapped into
    > unlikely(), which is why I presume it wasn't picked up. It would be
    > great if you could improve your coccinelle script to handle
    > {un,}likely() as well.

    Thanks for your suggestion.

    Should I consider any more fine-tuning for the affected script
    "list_input_parameter_validation1.cocci" in the near future?
    https://lkml.org/lkml/2014/3/5/362
    http://article.gmane.org/gmane.comp.version-control.coccinelle/3514


    >> @@ -590,15 +589,13 @@ static void queue_realm_cap_snaps(struct ceph_snap_realm
    >> *realm)
    >
    > The patch was corrupted, that should have been a single line. I fixed
    > it up but you may want to look into your email client settings.

    Thanks for your feedback.

    Does this example show a conflict between long comments after patch ranges and
    line length limitation for email eventually?

    Regards,
    Markus


    \
     
     \ /
      Last update: 2014-11-03 14:41    [W:4.033 / U:0.436 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site