lkml.org 
[lkml]   [2014]   [Nov]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] Add ltc3562 voltage regulator driver
On Mon, Nov 03, 2014 at 09:10:08AM +0100, Mike Looijmans wrote:
> On 10/30/2014 05:51 PM, Mark Brown wrote:

> >>+ np_child = of_get_child_by_name(np_regulators,
> >>+ ltc3562_regulators[i].name);
> >>+ if (np_child == NULL) {

> >Use the core support for looking up constraints please - set
> >regulators_node and so on.

> I've been reworking the driver, but this is the only feedback comment I
> didn't quite understand. What is it that I'm expected to do here? Probably
> just the name of the method I'm supposed to call here would be enough.

No function calls, just use regulators_node. What is unclear about the
functionality?
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2014-11-03 13:41    [W:0.536 / U:0.212 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site