lkml.org 
[lkml]   [2014]   [Nov]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/1] s390/net: Deletion of unnecessary checks before two function calls
    This one is buggy.

    I'm sorry, but please stop sending these.

    For kfree(), at least we all know that kfree() accepts NULL pointer.
    But for this one:
    1) I don't know what the functions do so I have to look at the code.
    2) It's in a arch that I don't compile so cscope isn't set up meaning
    it's hard to find the functions.

    You're sending a lot of patches and they are all hard to review and some
    of them are buggy and none of them really add any value. It's a waste
    of your time and it's a waste of my time.

    regards,
    dan carpenter


    \
     
     \ /
      Last update: 2014-11-03 11:01    [W:4.036 / U:0.952 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site