lkml.org 
[lkml]   [2014]   [Nov]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/2] ALSA: echoaudio: remove all snd_printk
At Mon,  3 Nov 2014 14:16:23 +0530,
Sudip Mukherjee wrote:
>
> @@ -98,7 +99,7 @@ static int init_hw(struct echoaudio *chip, u16 device_id, u16 subdevice_id)
> ECHOCAPS_HAS_DIGITAL_MODE_SPDIF_OPTICAL |
> ECHOCAPS_HAS_DIGITAL_MODE_ADAT;
>
> - DE_INIT(("init_hw done\n"));
> + dev_info(chip->card->dev, "init_hw done\n");

This (and the rest of all dev_info() in your patch) should be
dev_dbg(). They are no really useful information to be shown at each
time the module is loaded. ("init_hw done"? Yeah, why not, when the
module is loaded successfully :)


thanks,

Takashi


\
 
 \ /
  Last update: 2014-11-03 11:01    [W:0.041 / U:0.848 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site