lkml.org 
[lkml]   [2014]   [Nov]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] reset: add socfpga_reset_status
From
Date
Hi Dinh,

Am Freitag, den 24.10.2014, 10:53 -0500 schrieb
dinguyen@opensource.altera.com:
> From: Dinh Nguyen <dinguyen@opensource.altera.com>
>
> Populate the reset_status callback for SOCFPGA.
>
> Signed-off-by: Alan Tull <atull@opensource.altera.com>
> Signed-off-by: Dinh Nguyen <dinguyen@opensource.altera.com>
> ---
> drivers/reset/reset-socfpga.c | 18 ++++++++++++++++++
> 1 file changed, 18 insertions(+)
>
> diff --git a/drivers/reset/reset-socfpga.c b/drivers/reset/reset-socfpga.c
> index 79c32ca..cd37849 100644
> --- a/drivers/reset/reset-socfpga.c
> +++ b/drivers/reset/reset-socfpga.c
> @@ -76,9 +76,27 @@ static int socfpga_reset_deassert(struct reset_controller_dev *rcdev,
> return 0;
> }
>
> +static int socfpga_reset_status(struct reset_controller_dev *rcdev,
> + unsigned long id)
> +{
> + struct socfpga_reset_data *data = container_of(rcdev,
> + struct socfpga_reset_data, rcdev);
> + int bank = id / BITS_PER_LONG;
> + int offset = id % BITS_PER_LONG;
> + unsigned long flags;
> + u32 reg;
> +
> + spin_lock_irqsave(&data->lock, flags);
> + reg = readl(data->membase + OFFSET_MODRST + (bank * NR_BANKS));
> + spin_unlock_irqrestore(&data->lock, flags);

For the register read access, you don't need the lock.

> + return !(reg & BIT(offset));
> +}
> +
> static struct reset_control_ops socfpga_reset_ops = {
> .assert = socfpga_reset_assert,
> .deassert = socfpga_reset_deassert,
> + .status = socfpga_reset_status,
> };
>
> static int socfpga_reset_probe(struct platform_device *pdev)

regards
Philipp



\
 
 \ /
  Last update: 2014-11-03 10:21    [W:0.065 / U:0.204 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site