lkml.org 
[lkml]   [2014]   [Nov]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH usb v4 17/27] host: ehci-orion: remove duplicate check on resource
    Date
    From: Varka Bhadram <varkabhadram@gmail.com>

    Sanity check on resource happening with devm_ioremap_resource().

    Signed-off-by: Varka Bhadram <varkab@cdac.in>
    Acked-by: Alan Stern <stern@rowland.harvard.edu>
    Reviewed-by: Gregory CLEMENT <gregory.clement@free-electrons.com>
    ---
    drivers/usb/host/ehci-orion.c | 10 +---------
    1 file changed, 1 insertion(+), 9 deletions(-)

    diff --git a/drivers/usb/host/ehci-orion.c b/drivers/usb/host/ehci-orion.c
    index 22e15ca..36b4657 100644
    --- a/drivers/usb/host/ehci-orion.c
    +++ b/drivers/usb/host/ehci-orion.c
    @@ -175,15 +175,6 @@ static int ehci_orion_drv_probe(struct platform_device *pdev)
    goto err;
    }

    - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
    - if (!res) {
    - dev_err(&pdev->dev,
    - "Found HC with no register addr. Check %s setup!\n",
    - dev_name(&pdev->dev));
    - err = -ENODEV;
    - goto err;
    - }
    -
    /*
    * Right now device-tree probed devices don't get dma_mask
    * set. Since shared usb code relies on it, set it here for
    @@ -193,6 +184,7 @@ static int ehci_orion_drv_probe(struct platform_device *pdev)
    if (err)
    goto err;

    + res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
    regs = devm_ioremap_resource(&pdev->dev, res);
    if (IS_ERR(regs)) {
    err = PTR_ERR(regs);
    --
    1.7.9.5


    \
     
     \ /
      Last update: 2014-11-04 03:41    [W:2.289 / U:0.180 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site