Messages in this thread | | | Date | Fri, 28 Nov 2014 11:54:37 +0300 | From | Dan Carpenter <> | Subject | Re: [PATCH 1/2] mfd: rtsx: add func to split u32 into register |
| |
On Fri, Nov 28, 2014 at 02:10:36AM +0000, 敬锐 wrote: > eg, in sd_ops.c the cmd.arg is constructed bit by bit, we can put the right > byte to the right register by shift, so the endian check is not need.
I looked at drivers/mmc/core/sd_ops.c and cmd.arg seems to be cpu endian.
The new function assumes that the cpu is little endian and manually converts it to little endian. This is an endian bug. I think my fix is correct or something similar.
regards, dan carpenter
| |