Messages in this thread | | | From | "Rafael J. Wysocki" <> | Subject | Re: [Replacement][PATCH 1/4] PM: Merge the SET*_RUNTIME_PM_OPS() macros | Date | Sat, 29 Nov 2014 01:52:32 +0100 |
| |
On Thursday, November 27, 2014 11:05:41 PM Rafael J. Wysocki wrote: > From: Rafael J. Wysocki <rafael.j.wysocki@intel.com> > > The SET_PM_RUNTIME_PM_OPS() and SET_RUNTIME_PM_OPS() macros are > identical except that one of them is not empty for CONFIG_PM set, > while the other one is not empty for CONFIG_PM_RUNTIME set, > respectively. > > However, after commit b2b49ccbdd54 (PM: Kconfig: Set PM_RUNTIME if > PM_SLEEP is selected) PM_RUNTIME is always set if PM is set, so one > of these macros is now redundant. > > For this reason, replace SET_PM_RUNTIME_PM_OPS() with > SET_RUNTIME_PM_OPS() everywhere and redefine the SET_PM_RUNTIME_PM_OPS > symbol as SET_RUNTIME_PM_OPS in case new code is starting to use the > macro being removed here.
It turns out that I need to defer this one, because it breaks builds for CONFIG_PM selected without CONFIG_PM_SLEEP or CONFIG_PM_RUNTIME (which is arguably invalid, but some defconfigs evidently do that).
I need to fix those defconfigs first.
-- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center.
| |