Messages in this thread | | | From | OGAWA Hirofumi <> | Subject | Re: [PATCH] fat: Fix oops on corrupted vfat fs | Date | Thu, 27 Nov 2014 16:00:41 +0900 |
| |
Andrew Morton <akpm@linux-foundation.org> writes:
> On Thu, 27 Nov 2014 00:31:28 +0900 OGAWA Hirofumi <hirofumi@mail.parknet.co.jp> wrote: > >> a) don't bother with ->d_time for positives - we only check it for negatives >> anyway. >> b) make sure to set it at unlink and rmdir time - at *that* point soon-to-be >> negative dentry matches then-current directory contents >> c) don't go into renaming of old alias in vfat_lookup() unless it has >> the same parent (which it will, unless we are seeing corrupted image) >> >> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk> >> Cc: <stable@vger.kernel.org> # 3.17.x >> [Make change minimum, don't call d_move() for dir] >> Signed-off-by: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp> > > It's unclear who did the "[Make change minimum.." alteration. > > I do it this way: > [hirofumi@mail.parknet.co.jp: make change minimum, don't call d_move() for dir]
I see. OK, I will also use your format next time.
> Also, who was the primary author of this patch? It *looks* like it was > Al, unsure. If it was indeed Al then this can be communicated by > putting his From: line at the very top of the changelog body.
Ah, sorry. The patch is written by Al, and I was forgetting to add "From:". -- OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
| |