Messages in this thread | | | Date | Thu, 27 Nov 2014 17:35:29 +0100 | From | Richard Weinberger <> | Subject | Re: [PATCH 3/6] UBI: Fastmap: Ensure that all fastmap work is done upon WL shutdown |
| |
Am 27.11.2014 um 17:29 schrieb Artem Bityutskiy: > On Thu, 2014-11-27 at 17:08 +0100, Richard Weinberger wrote: >>> Obviously, there is some misunderstanding. This looks like lack of >>> separation and misuse of layering. I am missing explanations why I am >>> wrong... >> >> So you want me to use the UBI WL background thread for the scheduled fastmap work? > > No. It is more like either use it or do not use it.
Sorry, I don't understand. What do you want to do to?
>> I didn't do it that way because you said more than once that fastmap is fastmap and >> WL is WL. Therefore I've separated it. > > And "separated" meaning adding this code to wl.c? > > +#ifdef CONFIG_MTD_UBI_FASTMAP > + flush_work(&ubi->fm_work); > +#endif > > Could it be separated some more then? >
Of course, commit "UBI: Move fastmap specific functions out of wl.c" does. But this commit is *bugfix* commit.
Thanks, //richard
| |