Messages in this thread | | | Date | Wed, 26 Nov 2014 10:13:50 +0100 | Subject | Re: [PATCH 1/5] hwmon: ina2xx: bail-out from ina2xx_probe() in case of configuration errors | From | Bartosz Golaszewski <> |
| |
2014-11-26 4:05 GMT+01:00 Guenter Roeck <linux@roeck-us.net>: > On 11/25/2014 10:30 AM, Guenter Roeck wrote: >> Repeating my earlier question: Is the resistor value changed by software >> or by changing the probe ? >> > > Looking into the available documents, I am quite sure that the resistor > is changed by replacing the probe, in other words by pulling the board > with the ina226 and replacing it with another one. Given that, configuring > the shunt resistor value with a sysfs attribute is really the wrong way > to do it; you should use probe specific devicetree overlays instead.
Yes, it's changed by replacing the probes.
As for the averaging rate: it's a programmable feature of the chip and it's useful for our user interface for noise reduction (or the opposite - to be able to see the actual distortion), can this be accepted after applying the fixes according to your review?
Bart
| |