lkml.org 
[lkml]   [2014]   [Nov]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH V5 3/3] perf tool: check buildid for symoff
Date
Hi Kan,

On Mon, 24 Nov 2014 11:00:29 -0500, Kan Liang wrote:
> From: Kan Liang <kan.liang@intel.com>
>
> symoff can support both same binaries and different binaries. However,
> the offset may be changed for different binaries. This patch checks the
> buildid of perf.data. If they are from different binaries, print a
> warning to notify the user.

Hmm.. I think that perf diff is supposed to compare performance between
different (i.e. modified) binaries. So there's a little point to print
the warning IMHO - but I'm not insist it strongly..

Anyway, I think what we really need for the warning is different version
of same binary. For example, if data file 1 has DSO A and B, and data
file 2 has DSO B and C, we should not consider they're different (unless
build-ids of B in data file 1 and 2 are different) since A and C won't
affect symoff comparision.

Thanks,
Namhyung


\
 
 \ /
  Last update: 2014-11-27 03:41    [W:0.088 / U:0.024 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site