Messages in this thread Patch in this message | | | Date | Thu, 27 Nov 2014 00:54:34 +0100 | From | Oleg Nesterov <> | Subject | [PATCH v2 1/2] exit: pidns: alloc_pid() leaks pid_namespace if child_reaper is exiting |
| |
alloc_pid() does get_pid_ns() beforehand but forgets to put_pid_ns() if it fails because disable_pid_allocation() was called by the exiting child_reaper.
We could simply move get_pid_ns() down to successful return, but this fix tries to be as trivial as possible.
Signed-off-by: Oleg Nesterov <oleg@redhat.com> Cc: stable@vger.kernel.org --- kernel/pid.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/kernel/pid.c b/kernel/pid.c index 9b9a266..82430c8 100644 --- a/kernel/pid.c +++ b/kernel/pid.c @@ -341,6 +341,8 @@ out: out_unlock: spin_unlock_irq(&pidmap_lock); + put_pid_ns(ns); + out_free: while (++i <= ns->level) free_pidmap(pid->numbers + i); -- 1.5.5.1
| |