lkml.org 
[lkml]   [2014]   [Nov]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC][PATCH 0/9 v2] ftrace/x86: Clean up of mcount.S code
On Tue, 25 Nov 2014, Steven Rostedt wrote:
> I ran these through my test suite and they passed. Are these changes
> fine for you? If so, I'll include them in my 3.19 queue.
>
> I still think the "band-aid patch" should go into 3.18 now, as it does
> fix a real bug, and is small and less likely to cause any regressions that
> this patch series might do. Which also makes it a candidate for stable.

Bah. It confused the hell out of me to figure out what that band aid
patch would be in the series.

So you are referring to the patch which I acked already, and which
caused Linus to stick his nose into that code.

Right, we really should (ignoring the ugliness) push that back into
stable. Having debug infrastructure which provides half baken
information is a real pain. I wasted days in the past just to figure
out that the tracer was giving me incomplete information or refusing
to stop when I wanted it to. I rather prefer a tool to be 'slow' than
disfunctional.

Thanks,

tglx


\
 
 \ /
  Last update: 2014-11-26 23:41    [W:0.058 / U:1.492 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site