Messages in this thread | | | Date | Wed, 26 Nov 2014 18:55:48 +0100 | From | Daniel Borkmann <> | Subject | Re: [PATCH] x86: bpf_jit_comp: simplify trivial boolean return |
| |
On 11/26/2014 05:58 PM, Joe Perches wrote: ... >> imo existing code is fine and I don't think the time spent >> reviewing such changes is worth it when there is no >> improvement in readability.
+1
> Is there any value in reordering these tests for frequency > or maybe using | instead of || to avoid multiple jumps?
No, it's not a fast-path.
| |