Messages in this thread | | | Date | Wed, 26 Nov 2014 15:49:34 +0100 | From | Radim Krčmář <> | Subject | Re: Another Obsolete Fix me in trace.h? |
| |
2014-11-26 09:15-0500, Steven Rostedt: > On Wed, 26 Nov 2014 13:40:26 +0100 > Radim Krčmář <rkrcmar@redhat.com> wrote: > > The kernel part is trivial. > > Most of the code is going to be in tools/lib/traceevent/event-parse.c. > > > > I wasn't sure whether to > > 1) define new 'enum print_arg_type' for our function and do exactly what > > other __print* did > > 2) extend existing PRINT_FUNC with variable arguments and register it as > > a "global" event handler > > > > as (2) makes more sense to me, but we already had it when some __print* > > was implemented ... (and I didn't want to dig too deep into the project) > > Add a new hardcoded instance. The PRINT_FUNC is for plugins that have a > unique function for the events they handle. Notice that event-parse > does not define any func handlers. If this is to be generic, then lets > make it specified as a new enum.
Ok, thanks.
(It just seemed weird that we have an infrastructure that could allow a "generic plugin" to cover this functionality.)
| |