Messages in this thread | | | Date | Wed, 26 Nov 2014 16:05:39 +0200 | From | "Michael S. Tsirkin" <> | Subject | Re: [PATCH v4 25/42] vhost: add memory access wrappers |
| |
On Wed, Nov 26, 2014 at 02:54:38PM +0100, Cornelia Huck wrote: > On Tue, 25 Nov 2014 18:43:10 +0200 > "Michael S. Tsirkin" <mst@redhat.com> wrote: > > "These wrappers are needed to handle virtio endianness conversions." > > ?
yes, it's same as virtio ones. I'll add this text, thanks.
> > Signed-off-by: Michael S. Tsirkin <mst@redhat.com> > > --- > > drivers/vhost/vhost.h | 33 ++++++++++++++++++++++++++++++++- > > 1 file changed, 32 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/vhost/vhost.h b/drivers/vhost/vhost.h > > index 3eda654..b9032e8 100644 > > --- a/drivers/vhost/vhost.h > > +++ b/drivers/vhost/vhost.h > > @@ -174,6 +174,37 @@ enum { > > > > static inline int vhost_has_feature(struct vhost_virtqueue *vq, int bit) > > { > > - return vq->acked_features & (1 << bit); > > + return vq->acked_features & (1ULL << bit); > > Should this hunk go into patch 28?
Well, this is needed here since 1 << 32 is not legal C.
I can move it - this means patch 28 will have to move earlier in series though.
> > +}
| |