lkml.org 
[lkml]   [2014]   [Nov]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] kbuild: collect shorthands into scripts/Kbuild.include
On Wed, Nov 26, 2014 at 07:31:13PM +0900, Masahiro Yamada wrote:
> The shorthand "clean" is defined in both the top Makefile and
> scripts/Makefile.clean. Likewise, the "hdr-inst" is defined in
> both the top Makefile and scripts/Makefile.headersinst.
>
> To reduce code duplication, this commit collects them into
> scripts/Kbuild.include like the "build" and "modbuiltin" shorthands.
> It requires scripts/Makefile.clean to include scripts/Kbuild.include,
> but its impact on the performance of "make clean" should be
> negligible.
>
> Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
> ---
>
> Marek, please decide if this patch should be applied or not.
>
> I am not so sure if 10% of performance regression is acceptable.
> I do not mind at all if this patch is rejected.
>
> Before this commit, on my box,
>
> $ time make clean
>
> real 0m2.916s
> user 0m1.040s
> sys 0m2.005s
>
> After,
>
> real 0m3.221s
> user 0m1.109s
> sys 0m2.271s

0.3s is even less than my guess. And as I said, you can run make clean
in parallel, so I'm not thrilled. Applied to kbuild.git#kbuild.

Thanks,
Michal


\
 
 \ /
  Last update: 2014-11-26 15:22    [W:0.046 / U:0.184 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site