lkml.org 
[lkml]   [2014]   [Nov]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.16.y-ckt 182/254] Input: alps - ignore potential bare packets when device is out of sync
    Date
    3.16.7-ckt2 -stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: =?UTF-8?q?Pali=20Roh=C3=A1r?= <pali.rohar@gmail.com>

    commit 4ab8f7f320f91f279c3f06a9795cfea5c972888a upstream.

    5th and 6th byte of ALPS trackstick V3 protocol match condition for first
    byte of PS/2 3 bytes packet. When driver enters out of sync state and ALPS
    trackstick is sending data then driver match 5th, 6th and next 1st bytes as
    PS/2.

    It basically means if user is using trackstick when driver is in out of
    sync state driver will never resync. Processing these bytes as 3 bytes PS/2
    data cause total mess (random cursor movements, random clicks) and make
    trackstick unusable until psmouse driver decide to do full device reset.

    Lot of users reported problems with ALPS devices on Dell Latitude E6440,
    E6540 and E7440 laptops. ALPS device or Dell EC for unknown reason send
    some invalid ALPS PS/2 bytes which cause driver out of sync. It looks like
    that i8042 and psmouse/alps driver always receive group of 6 bytes packets
    so there are no missing bytes and no bytes were inserted between valid
    ones.

    This patch does not fix root of problem with ALPS devices found in Dell
    Latitude laptops but it does not allow to process some (invalid)
    subsequence of 6 bytes ALPS packets as 3 bytes PS/2 when driver is out of
    sync.

    So with this patch trackstick input device does not report bogus data when
    also driver is out of sync, so trackstick should be usable on those
    machines.

    Signed-off-by: Pali Rohár <pali.rohar@gmail.com>
    Tested-by: Pali Rohár <pali.rohar@gmail.com>
    Reviewed-by: Hans de Goede <hdegoede@redhat.com>
    Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
    Signed-off-by: Luis Henriques <luis.henriques@canonical.com>
    ---
    drivers/input/mouse/alps.c | 8 +++++++-
    1 file changed, 7 insertions(+), 1 deletion(-)

    diff --git a/drivers/input/mouse/alps.c b/drivers/input/mouse/alps.c
    index fb15c64ffb95..873c0e024889 100644
    --- a/drivers/input/mouse/alps.c
    +++ b/drivers/input/mouse/alps.c
    @@ -1047,7 +1047,13 @@ static psmouse_ret_t alps_process_byte(struct psmouse *psmouse)
    {
    struct alps_data *priv = psmouse->private;

    - if ((psmouse->packet[0] & 0xc8) == 0x08) { /* PS/2 packet */
    + /*
    + * Check if we are dealing with a bare PS/2 packet, presumably from
    + * a device connected to the external PS/2 port. Because bare PS/2
    + * protocol does not have enough constant bits to self-synchronize
    + * properly we only do this if the device is fully synchronized.
    + */
    + if (!psmouse->out_of_sync_cnt && (psmouse->packet[0] & 0xc8) == 0x08) {
    if (psmouse->pktcnt == 3) {
    alps_report_bare_ps2_packet(psmouse, psmouse->packet,
    true);
    --
    2.1.0


    \
     
     \ /
      Last update: 2014-11-25 12:21    [W:4.291 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site