Messages in this thread | | | Date | Mon, 24 Nov 2014 07:54:03 +0000 | From | "Jan Beulich" <> | Subject | Re: [PATCH] xen-pciback: drop SR-IOV VFs when PF driver unloads |
| |
>>> On 21.11.14 at 23:03, <konrad.wilk@oracle.com> wrote: > I rewrote it a bit to be more in the style of pciback: >[...] > [v2: Removed the switch statement, moved it about]
What you don't mention here is that you also removed the outer loop, yet that breaks functionality afaict: There can (and I suppose normally will) be multiple VFs needing device_release_driver() called when a single PF goes away.
Also I'm not really happy for a patch with my S-o-b underneath to introduce goto-s without real need.
Jan
| |