Messages in this thread Patch in this message | | | Date | Sun, 23 Nov 2014 17:10:18 +0100 | From | SF Markus Elfring <> | Subject | [PATCH 1/1] video: uvesafb: Deletion of an unnecessary check before the function call "platform_device_put" |
| |
From: Markus Elfring <elfring@users.sourceforge.net> Date: Sun, 23 Nov 2014 17:05:18 +0100
The platform_device_put() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> --- drivers/video/fbdev/uvesafb.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/video/fbdev/uvesafb.c b/drivers/video/fbdev/uvesafb.c index 509d452..17b2e8c 100644 --- a/drivers/video/fbdev/uvesafb.c +++ b/drivers/video/fbdev/uvesafb.c @@ -1923,8 +1923,7 @@ static int uvesafb_init(void) err = -ENOMEM; if (err) { - if (uvesafb_device) - platform_device_put(uvesafb_device); + platform_device_put(uvesafb_device); platform_driver_unregister(&uvesafb_driver); cn_del_callback(&uvesafb_cn_id); return err; -- 2.1.3
| |