lkml.org 
[lkml]   [2014]   [Nov]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH 1/1] video: fbdev-MMP: Deletion of an unnecessary check before the function call "mmp_unregister_path"
    From: Markus Elfring <elfring@users.sourceforge.net>
    Date: Sun, 23 Nov 2014 15:45:03 +0100

    The mmp_unregister_path() function tests whether its argument is NULL
    and then returns immediately. Thus the test around the call is not needed.

    This issue was detected by using the Coccinelle software.

    Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    ---
    drivers/video/fbdev/mmp/hw/mmp_ctrl.c | 3 +--
    1 file changed, 1 insertion(+), 2 deletions(-)

    diff --git a/drivers/video/fbdev/mmp/hw/mmp_ctrl.c b/drivers/video/fbdev/mmp/hw/mmp_ctrl.c
    index 8621a9f..3c12bd8 100644
    --- a/drivers/video/fbdev/mmp/hw/mmp_ctrl.c
    +++ b/drivers/video/fbdev/mmp/hw/mmp_ctrl.c
    @@ -441,8 +441,7 @@ static void path_deinit(struct mmphw_path_plat *path_plat)
    if (!path_plat)
    return;

    - if (path_plat->path)
    - mmp_unregister_path(path_plat->path);
    + mmp_unregister_path(path_plat->path);
    }

    static int mmphw_probe(struct platform_device *pdev)
    --
    2.1.3


    \
     
     \ /
      Last update: 2014-11-23 16:41    [W:4.045 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site