Messages in this thread Patch in this message | | | From | Kevin Cernekee <> | Subject | [PATCH V3 04/11] irqchip: bcm7120-l2: fix error handling of irq_of_parse_and_map | Date | Sun, 23 Nov 2014 18:40:39 -0800 |
| |
From: Dmitry Torokhov <dtor@chromium.org>
Return value of irq_of_parse_and_map() is unsigned int, with 0 indicating failure, so testing for negative result never works.
Signed-off-by: Dmitry Torokhov <dtor@chromium.org> Acked-by: Florian Fainelli <f.fainelli@gmail.com> Tested-by: Kevin Cernekee <cernekee@gmail.com> --- drivers/irqchip/irq-bcm7120-l2.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/irqchip/irq-bcm7120-l2.c b/drivers/irqchip/irq-bcm7120-l2.c index e7c6155b23b8..8eec8e1201d9 100644 --- a/drivers/irqchip/irq-bcm7120-l2.c +++ b/drivers/irqchip/irq-bcm7120-l2.c @@ -102,9 +102,9 @@ static int bcm7120_l2_intc_init_one(struct device_node *dn, unsigned int idx; parent_irq = irq_of_parse_and_map(dn, irq); - if (parent_irq < 0) { + if (!parent_irq) { pr_err("failed to map interrupt %d\n", irq); - return parent_irq; + return -EINVAL; } /* For multiple parent IRQs with multiple words, this looks like: -- 2.1.1
| |