Messages in this thread | | | From | "Luck, Tony" <> | Subject | RE: [PATCH] sb_edac: Add support for Broadwell-DE processor | Date | Fri, 21 Nov 2014 21:21:45 +0000 |
| |
>> + { PCI_DESCR(PCI_DEVICE_ID_INTEL_BROADWELL_IMC_HA0_TAD2, 1) }, >> + { PCI_DESCR(PCI_DEVICE_ID_INTEL_BROADWELL_IMC_HA0_TAD3, 1) }, > > You are marking TAD2 and TAD3 as optional here, but > >> + for (i = 0; i < NUM_CHANNELS; i++) { >> + if (!pvt->pci_tad[i]) >> + goto enodev; >> + } > > It's not optional here.
Heh. Cut & paste from the HASWELL version which has the same issue. So we need to fix there too.
Thanks for the review.
-Tony
| |