Messages in this thread | | | Date | Fri, 21 Nov 2014 15:17:35 -0500 (EST) | Subject | Re: [PATCH 1/2] net/am2150: fix nmclan_cs.c shared interrupt handling | From | David Miller <> |
| |
From: Arnd Bergmann <arnd@arndb.de> Date: Thu, 20 Nov 2014 16:11:14 +0100
> A recent patch tried to work around a valid warning for the use of a > deprecated interface by blindly changing from the old > pcmcia_request_exclusive_irq() interface to pcmcia_request_irq(). > > This driver has an interrupt handler that is not currently aware > of shared interrupts, but can be easily converted to be. > At the moment, the driver reads the interrupt status register > repeatedly until it contains only zeroes in the interesting bits, > and handles each bit individually. > > This patch adds the missing part of returning IRQ_NONE in case none > of the bits are set to start with, so we can move on to the next > interrupt source. > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > Fixes: 5f5316fcd08ef7 ("am2150: Update nmclan_cs.c to use update PCMCIA API") > --- > I had this patch in my queue of things to submit and noticed that > the warning had gone away upstream but my patch was still there. > > For all I can tell, the driver is broken without this, although it > would rarely be a problem.
I'm happy for this to go alongside patch #2 via another tree:
Acked-by: David S. Miller <davem@davemloft.net>
| |