Messages in this thread | | | Date | Fri, 21 Nov 2014 09:19:02 -0800 | Subject | Re: frequent lockups in 3.18rc4 | From | Linus Torvalds <> |
| |
On Fri, Nov 21, 2014 at 9:08 AM, Steven Rostedt <rostedt@goodmis.org> wrote: > > Actually, in_nmi() is now safe for vmalloc faults. In fact, it handles the > clobbering of the cr2 register just fine.
That's not what I object to and find incorrect wrt NMI.
Compare the simple and correct 32-bit code to the complex and incorrect 64-bit code.
In particular, look at how the 32-bit code relies *entirely* on hardware state.
Then look at where the 64-bit code does not.
Linus
| |