Messages in this thread | | | Date | Fri, 21 Nov 2014 16:48:39 +0100 | From | SF Markus Elfring <> | Subject | Re: USB: serial: Deletion of an unnecessary check before the function call "release_firmware" |
| |
>> diff --git a/drivers/usb/serial/mxuport.c b/drivers/usb/serial/mxuport.c >> index ab1d690..3653ec1 100644 >> --- a/drivers/usb/serial/mxuport.c >> +++ b/drivers/usb/serial/mxuport.c >> @@ -1101,8 +1101,7 @@ static int mxuport_probe(struct usb_serial *serial, >> */ >> usb_set_serial_data(serial, (void *)id->driver_info); >> out: >> - if (fw_p) >> - release_firmware(fw_p); >> + release_firmware(fw_p); > > I think that the if should stay.
I have got an other opinion.
> There were two cases on the allocation, so there should be two cases > on the release.
I find that this implementation detail does not really matter for the necessity of a null pointer check directly before such a function call.
Regards, Markus
| |