Messages in this thread | | | Date | Fri, 21 Nov 2014 15:29:09 +0000 | From | Russell King - ARM Linux <> | Subject | Re: [PATCH v9 05/13] arm: introduce is_device_dma_coherent |
| |
On Thu, Nov 20, 2014 at 10:39:32AM +0000, Stefano Stabellini wrote: > On Thu, 20 Nov 2014, Russell King - ARM Linux wrote: > > On Tue, Nov 18, 2014 at 04:49:21PM +0000, Stefano Stabellini wrote: > > > ping? > > > > Sending something which wants my attention _To:_ me is always a good idea :) > > I'll keep that in mind :-) > > > > The patch is fine in itself, but I have a niggle about the > > is_device_dma_coherent() - provided this is only used in architecture > > specific code, that should be fine. It could probably do with a comment > > to that effect in an attempt to discourage drivers using it (thereby > > becoming less portable to other architectures.) > > Can I take this as an Acked-by? > Good point regarding the comment. Maybe I can add: > > /* do not use this function in a driver */
Provided it gets such a comment, yes. Thanks.
-- FTTC broadband for 0.8mile line: currently at 9.5Mbps down 400kbps up according to speedtest.net.
| |