Messages in this thread Patch in this message | | | Date | Fri, 21 Nov 2014 14:55:44 +0100 | From | SF Markus Elfring <> | Subject | [PATCH 1/1] USB: gadget: function: Deletion of an unnecessary check before the function call "rndis_add_hdr" |
| |
From: Markus Elfring <elfring@users.sourceforge.net> Date: Fri, 21 Nov 2014 14:51:43 +0100
The rndis_add_hdr() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> --- drivers/usb/gadget/function/f_rndis.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/usb/gadget/function/f_rndis.c b/drivers/usb/gadget/function/f_rndis.c index ddb09dc..da56a5f 100644 --- a/drivers/usb/gadget/function/f_rndis.c +++ b/drivers/usb/gadget/function/f_rndis.c @@ -375,8 +375,7 @@ static struct sk_buff *rndis_add_header(struct gether *port, struct sk_buff *skb2; skb2 = skb_realloc_headroom(skb, sizeof(struct rndis_packet_msg_type)); - if (skb2) - rndis_add_hdr(skb2); + rndis_add_hdr(skb2); dev_kfree_skb(skb); return skb2; -- 2.1.3
| |