lkml.org 
[lkml]   [2014]   [Nov]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH 1/1] tty-hvsi_lib: Deletion of an unnecessary check before the function call "tty_kref_put"
    From: Markus Elfring <elfring@users.sourceforge.net>
    Date: Fri, 21 Nov 2014 12:40:32 +0100

    The tty_kref_put() function tests whether its argument is NULL and then
    returns immediately. Thus the test around the call is not needed.

    This issue was detected by using the Coccinelle software.

    Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    ---
    drivers/tty/hvc/hvsi_lib.c | 3 +--
    1 file changed, 1 insertion(+), 2 deletions(-)

    diff --git a/drivers/tty/hvc/hvsi_lib.c b/drivers/tty/hvc/hvsi_lib.c
    index 7ae6c29..a270f04 100644
    --- a/drivers/tty/hvc/hvsi_lib.c
    +++ b/drivers/tty/hvc/hvsi_lib.c
    @@ -405,8 +405,7 @@ void hvsilib_close(struct hvsi_priv *pv, struct hvc_struct *hp)
    hvsi_send_close(pv);
    }

    - if (pv->tty)
    - tty_kref_put(pv->tty);
    + tty_kref_put(pv->tty);
    pv->tty = NULL;
    }

    --
    2.1.3


    \
     
     \ /
      Last update: 2014-11-21 13:21    [W:4.019 / U:0.736 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site