Messages in this thread Patch in this message | | | Date | Fri, 21 Nov 2014 11:40:37 +0100 | From | SF Markus Elfring <> | Subject | [PATCH 1/1] thunderbolt: Deletion of unnecessary checks before the function call "ring_free" |
| |
From: Markus Elfring <elfring@users.sourceforge.net> Date: Fri, 21 Nov 2014 11:30:18 +0100
The ring_free() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> --- drivers/thunderbolt/ctl.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/thunderbolt/ctl.c b/drivers/thunderbolt/ctl.c index 799634b..55b9bdf 100644 --- a/drivers/thunderbolt/ctl.c +++ b/drivers/thunderbolt/ctl.c @@ -520,10 +520,8 @@ err: void tb_ctl_free(struct tb_ctl *ctl) { int i; - if (ctl->rx) - ring_free(ctl->rx); - if (ctl->tx) - ring_free(ctl->tx); + ring_free(ctl->rx); + ring_free(ctl->tx); /* free RX packets */ for (i = 0; i < TB_CTL_RX_PKG_COUNT; i++) -- 2.1.3
| |