lkml.org 
[lkml]   [2014]   [Nov]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH 1/1] SCSI-fnic: Deletion of an unnecessary check before the function call "vfree"
    From: Markus Elfring <elfring@users.sourceforge.net>
    Date: Fri, 21 Nov 2014 09:39:43 +0100

    The vfree() function performs also input parameter validation. Thus the test
    around the call is not needed.

    This issue was detected by using the Coccinelle software.

    Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    ---
    drivers/scsi/fnic/fnic_debugfs.c | 3 +--
    1 file changed, 1 insertion(+), 2 deletions(-)

    diff --git a/drivers/scsi/fnic/fnic_debugfs.c b/drivers/scsi/fnic/fnic_debugfs.c
    index 2c613bd..ec70e6d 100644
    --- a/drivers/scsi/fnic/fnic_debugfs.c
    +++ b/drivers/scsi/fnic/fnic_debugfs.c
    @@ -102,8 +102,7 @@ void fnic_debugfs_terminate(void)
    debugfs_remove(fnic_trace_debugfs_root);
    fnic_trace_debugfs_root = NULL;

    - if (fc_trc_flag)
    - vfree(fc_trc_flag);
    + vfree(fc_trc_flag);
    }

    /*
    --
    2.1.3


    \
     
     \ /
      Last update: 2014-11-21 10:21    [W:4.020 / U:3.076 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site