Messages in this thread Patch in this message | | | From | Anil Gurumurthy <> | Subject | RE: [PATCH 1/1] SCSI-bfa: Deletion of an unnecessary check before the function call "vfree" | Date | Fri, 21 Nov 2014 04:20:04 +0000 |
| |
Patch looks good. Thanks! Acked-by: Anil Gurumurthy <anil.gurumurthy@qlogic.com>
-----Original Message----- From: SF Markus Elfring [mailto:elfring@users.sourceforge.net] Sent: 21 November 2014 04:17 To: Anil Gurumurthy; James E. J. Bottomley; Sudarsana Kalluru; linux-scsi Cc: linux-kernel; kernel-janitors@vger.kernel.org; Julia Lawall Subject: [PATCH 1/1] SCSI-bfa: Deletion of an unnecessary check before the function call "vfree"
From: Markus Elfring <elfring@users.sourceforge.net> Date: Thu, 20 Nov 2014 23:43:17 +0100
The vfree() function performs also input parameter validation. Thus the test around the call is not needed.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> --- drivers/scsi/bfa/bfad_debugfs.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/scsi/bfa/bfad_debugfs.c b/drivers/scsi/bfa/bfad_debugfs.c index 8e83d04..a72170f 100644 --- a/drivers/scsi/bfa/bfad_debugfs.c +++ b/drivers/scsi/bfa/bfad_debugfs.c @@ -399,8 +399,7 @@ bfad_debugfs_release_fwtrc(struct inode *inode, struct file *file) if (!fw_debug) return 0; - if (fw_debug->debug_buffer) - vfree(fw_debug->debug_buffer); + vfree(fw_debug->debug_buffer); file->private_data = NULL; kfree(fw_debug); -- 2.1.3
| |