lkml.org 
[lkml]   [2014]   [Nov]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] drivers/rtc/interface.c: check the validation of rtc_time in __rtc_read_time
On Tue, Oct 14, 2014 at 03:21:31PM -0700, Andrew Morton wrote:
> On Wed, 8 Oct 2014 11:05:29 +0900 Hyogi Gim <ciogenis@gmail.com> wrote:
>
> > Some of rtc devices always return '0' when rtc_class_ops.read_time is called.
> > So if rtc_time isn't verified in callback, rtc interface cannot know whether
> > rtc_time is valid.
>
> We should fix the buggy .read_time() implementations...
>

Thanks for comments.
I'm studying rtc framework and trying to find a problem.
This is a minor bug. But, as you know, it can be a big problem for
newbies like me.

Even though it was late, I send you reply because a question.
If this patch is merged, rtc_valid_tm() in rtc_class_ops.read_time
callback is not necessary anymore.
So, I think each rtc device driver should change the code.
I can change the code. But, test is a little different.

In this case, how can I progress this modification?
Can I just send the notification for rtc_valid_tm() to the driver
manufacturer? or, request test for the code that I've modified?

--
Hyogi



\
 
 \ /
  Last update: 2014-11-21 03:41    [W:0.074 / U:0.104 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site