Messages in this thread | | | Date | Thu, 20 Nov 2014 14:58:39 -0700 | From | Shuah Khan <> | Subject | Re: [PATCH v2] selftest: size: Add size test for Linux kernel |
| |
On 11/19/2014 05:13 PM, Tim Bird wrote: > > This test shows the amount of memory used by the system. > Note that this is dependent on the user-space that is loaded > when this program runs. Optimally, this program would be > run as the init program itself. > > The program is optimized for size itself, to avoid conflating > its own execution with that of the system software. > The code is compiled statically, with no stdlibs. On my x86_64 system, > this results in a statically linked binary of less than 5K. > > Changes from v1: > - use more correct Copyright string in get_size.c > > Signed-off-by: Tim Bird <tim.bird@sonymobile.com> > --- > tools/testing/selftests/Makefile | 1 + > tools/testing/selftests/size/Makefile | 21 +++++++ > tools/testing/selftests/size/get_size.c | 105 ++++++++++++++++++++++++++++++++ > 3 files changed, 127 insertions(+) > create mode 100644 tools/testing/selftests/size/Makefile > create mode 100644 tools/testing/selftests/size/get_size.c
Tim,
The test looks good, but you are missing .gitignore file. Please add a .gitignore for the binary that gets generated to avoid git status including the binary it in its output.
thanks, -- Shuah
-- Shuah Khan Sr. Linux Kernel Developer Samsung Research America (Silicon Valley) shuahkh@osg.samsung.com | (970) 217-8978
| |