Messages in this thread Patch in this message | | | Date | Thu, 20 Nov 2014 20:42:19 +0100 | From | SF Markus Elfring <> | Subject | [PATCH 1/1] SCSI-eata_pio: Deletion of an unnecessary check before the function call "pci_dev_put" |
| |
From: Markus Elfring <elfring@users.sourceforge.net> Date: Thu, 20 Nov 2014 20:37:30 +0100
The pci_dev_put() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> --- drivers/scsi/eata_pio.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/scsi/eata_pio.c b/drivers/scsi/eata_pio.c index 8319d2b..707f64d 100644 --- a/drivers/scsi/eata_pio.c +++ b/drivers/scsi/eata_pio.c @@ -122,8 +122,7 @@ static int eata_pio_release(struct Scsi_Host *sh) release_region(sh->io_port, sh->n_io_port); } /* At this point the PCI reference can go */ - if (hd->pdev) - pci_dev_put(hd->pdev); + pci_dev_put(hd->pdev); return 1; } -- 2.1.3
| |