lkml.org 
[lkml]   [2014]   [Nov]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH 1/1] SCSI-OSD: Deletion of an unnecessary check before the function call "put_disk"
    From: Markus Elfring <elfring@users.sourceforge.net>
    Date: Thu, 20 Nov 2014 18:11:28 +0100

    The put_disk() function tests whether its argument is NULL and then
    returns immediately. Thus the test around the call is not needed.

    This issue was detected by using the Coccinelle software.

    Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    ---
    drivers/scsi/osd/osd_uld.c | 3 +--
    1 file changed, 1 insertion(+), 2 deletions(-)

    diff --git a/drivers/scsi/osd/osd_uld.c b/drivers/scsi/osd/osd_uld.c
    index e1d9a4c..3d82ee1 100644
    --- a/drivers/scsi/osd/osd_uld.c
    +++ b/drivers/scsi/osd/osd_uld.c
    @@ -408,8 +408,7 @@ static void __remove(struct device *dev)
    OSD_INFO("osd_remove %s\n",
    oud->disk ? oud->disk->disk_name : NULL);

    - if (oud->disk)
    - put_disk(oud->disk);
    + put_disk(oud->disk);
    ida_remove(&osd_minor_ida, oud->minor);

    kfree(oud);
    --
    2.1.3


    \
     
     \ /
      Last update: 2014-11-20 19:01    [W:5.367 / U:1.796 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site