lkml.org 
[lkml]   [2014]   [Nov]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/1] [media] firewire: Deletion of an unnecessary check before the function call "dvb_unregister_device"
    On Nov 20 SF Markus Elfring wrote:
    > From: Markus Elfring <elfring@users.sourceforge.net>
    > Date: Thu, 20 Nov 2014 10:49:07 +0100
    >
    > The dvb_unregister_device() function tests whether its argument is NULL
    > and then returns immediately. Thus the test around the call is not needed.
    >
    > This issue was detected by using the Coccinelle software.
    >
    > Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>

    Reviewed-by: Stefan Richter <stefanr@s5r6.in-berlin.de>

    > ---
    > drivers/media/firewire/firedtv-ci.c | 3 +--
    > 1 file changed, 1 insertion(+), 2 deletions(-)
    >
    > diff --git a/drivers/media/firewire/firedtv-ci.c b/drivers/media/firewire/firedtv-ci.c
    > index e5ebdbf..e63f582 100644
    > --- a/drivers/media/firewire/firedtv-ci.c
    > +++ b/drivers/media/firewire/firedtv-ci.c
    > @@ -253,6 +253,5 @@ int fdtv_ca_register(struct firedtv *fdtv)
    >
    > void fdtv_ca_release(struct firedtv *fdtv)
    > {
    > - if (fdtv->cadev)
    > - dvb_unregister_device(fdtv->cadev);
    > + dvb_unregister_device(fdtv->cadev);
    > }



    --
    Stefan Richter
    -=====-====- =-== =-=--
    http://arcgraph.de/sr/


    \
     
     \ /
      Last update: 2014-11-20 16:21    [W:4.792 / U:0.824 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site