Messages in this thread | | | Date | Thu, 20 Nov 2014 10:40:08 +0530 | Subject | Re: [PATCH v3 1/5] arm64: Kprobes with single stepping support | From | Sandeepa Prabhu <> |
| |
On 19 November 2014 20:25, David Long <dave.long@linaro.org> wrote: >> I was thinking of the magic hex numbers in the kprobes decode tables, >> which >> seem to correspond directly to the instruction classes described in insn.c >> >> Keeping the actual emulation code separate makes sense. >> >> Will > > > Of course that follows the model of the much more complex arm32 > kprobes/uprobes decoding. I can have a go at replacing it with insn.c > calls. well, the magic hex numbers were derived directly from ARMv8 ARM Tabled C4.1 thru C4.6 and bit-masking would be faster search, but surely you can give a try with insn.c (this would consume lot of function calls to arrive at same decision). ~Sandeepa > > -dl >
| |