lkml.org 
[lkml]   [2014]   [Nov]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH 1/1] net: Hyper-V: Deletion of an unnecessary check before the function call "vfree"
    From: Markus Elfring <elfring@users.sourceforge.net>
    Date: Thu, 20 Nov 2014 15:15:21 +0100

    The vfree() function performs also input parameter validation. Thus the test
    around the call is not needed.

    This issue was detected by using the Coccinelle software.

    Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    ---
    drivers/net/hyperv/netvsc.c | 3 +--
    1 file changed, 1 insertion(+), 2 deletions(-)

    diff --git a/drivers/net/hyperv/netvsc.c b/drivers/net/hyperv/netvsc.c
    index da2d346..ffe7481 100644
    --- a/drivers/net/hyperv/netvsc.c
    +++ b/drivers/net/hyperv/netvsc.c
    @@ -548,8 +548,7 @@ int netvsc_device_remove(struct hv_device *device)
    vmbus_close(device->channel);

    /* Release all resources */
    - if (net_device->sub_cb_buf)
    - vfree(net_device->sub_cb_buf);
    + vfree(net_device->sub_cb_buf);

    kfree(net_device);
    return 0;
    --
    2.1.3


    \
     
     \ /
      Last update: 2014-11-20 16:01    [W:4.020 / U:0.500 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site