Messages in this thread | | | Date | Thu, 20 Nov 2014 06:23:29 -0800 | From | Guenter Roeck <> | Subject | Re: [PATCHv5 1/1] thermal: of: improve of-thermal sensor registration API |
| |
On 11/20/2014 06:18 AM, Eduardo Valentin wrote: > Hi Guenter, > > On Thu, Nov 20, 2014 at 10:12:13AM -0400, Eduardo Valentin wrote: >> Different drivers request API extensions in of-thermal. For this reason, >> additional callbacks are required to fit the new drivers needs. >> >> The current API implementation expects the registering sensor driver >> to provide a get_temp and get_trend callbacks as function parameters. >> As the amount of callbacks is growing, this patch changes the existing >> implementation to use a .ops field to hold all the of thermal callbacks >> to sensor drivers. >> >> This patch also changes the existing of-thermal users to fit the new >> API design. No functional change is introduced in this patch. >> >> Cc: Alexandre Courbot <gnurou@gmail.com> >> Cc: devicetree@vger.kernel.org >> Cc: Grant Likely <grant.likely@linaro.org> >> Cc: Guenter Roeck <linux@roeck-us.net> >> Cc: Jean Delvare <jdelvare@suse.de> >> Cc: linux-kernel@vger.kernel.org >> Cc: linux-pm@vger.kernel.org >> Cc: linux-tegra@vger.kernel.org >> Cc: lm-sensors@lm-sensors.org >> Cc: Rob Herring <robh+dt@kernel.org> >> Cc: Stephen Warren <swarren@wwwdotorg.org> >> Cc: Thierry Reding <thierry.reding@gmail.com> >> Cc: Zhang Rui <rui.zhang@intel.com> >> Tested-by: Mikko Perttunen <mikko.perttunen@kapsi.fi> >> Reviewed-by: Mikko Perttunen <mikko.perttunen@kapsi.fi> >> Reviewed-by: Alexandre Courbot <acourbot@nvidia.com> >> Reviewed-by: Lukasz Majewski <l.majewski@samsung.com> >> Signed-off-by: Eduardo Valentin <edubezval@gmail.com> >> --- >> drivers/hwmon/lm75.c | 9 +++-- >> drivers/hwmon/ntc_thermistor.c | 6 +++- >> drivers/hwmon/tmp102.c | 6 +++- > > Do you have objections if I queue this one for 3.19? >
No.
Guenter
| |