Messages in this thread | | | Date | Thu, 20 Nov 2014 09:52:32 -0400 | From | Eduardo Valentin <> | Subject | Re: [PATCHv4 1/1] thermal: of: improve of-thermal sensor registration API |
| |
Alexander,
On Wed, Nov 19, 2014 at 05:06:24PM +0900, Alexandre Courbot wrote: > On Tue, Nov 18, 2014 at 11:39 PM, Eduardo Valentin <edubezval@gmail.com> wrote: > > Different drivers request API extensions in of-thermal. For this reason, > > additional callbacks are required to fit the new drivers needs. > > > > The current API implementation expects the registering sensor driver > > to provide a get_temp and get_trend callbacks as function parameters. > > As the amount of callbacks is growing, this patch changes the existing > > implementation to use a .ops field to hold all the of thermal callbacks > > to sensor drivers. > > > > This patch also changes the existing of-thermal users to fit the new > > API design. No functional change is introduced in this patch. > > A good idea even if no ops were to be added! > > Reviewed-by: Alexandre Courbot <acourbot@nvidia.com>
Thanks for reviewing.
Eduardo Valentin [unhandled content-type:application/pgp-signature] | |