lkml.org 
[lkml]   [2014]   [Nov]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH 1/1] MTD: Deletion of unnecessary checks before two function calls
    From: Markus Elfring <elfring@users.sourceforge.net>
    Date: Thu, 20 Nov 2014 13:50:43 +0100

    The functions kfree() and pci_dev_put() test whether their argument is NULL
    and then return immediately. Thus the test around the call is not needed.

    This issue was detected by using the Coccinelle software.

    Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    ---
    drivers/mtd/chips/cfi_cmdset_0001.c | 3 +--
    drivers/mtd/devices/pmc551.c | 3 +--
    2 files changed, 2 insertions(+), 4 deletions(-)

    diff --git a/drivers/mtd/chips/cfi_cmdset_0001.c b/drivers/mtd/chips/cfi_cmdset_0001.c
    index 3096f3d..286b97a 100644
    --- a/drivers/mtd/chips/cfi_cmdset_0001.c
    +++ b/drivers/mtd/chips/cfi_cmdset_0001.c
    @@ -2654,8 +2654,7 @@ static void cfi_intelext_destroy(struct mtd_info *mtd)
    kfree(cfi);
    for (i = 0; i < mtd->numeraseregions; i++) {
    region = &mtd->eraseregions[i];
    - if (region->lockmap)
    - kfree(region->lockmap);
    + kfree(region->lockmap);
    }
    kfree(mtd->eraseregions);
    }
    diff --git a/drivers/mtd/devices/pmc551.c b/drivers/mtd/devices/pmc551.c
    index f02603e..708b7e8 100644
    --- a/drivers/mtd/devices/pmc551.c
    +++ b/drivers/mtd/devices/pmc551.c
    @@ -812,8 +812,7 @@ static int __init init_pmc551(void)
    }

    /* Exited early, reference left over */
    - if (PCI_Device)
    - pci_dev_put(PCI_Device);
    + pci_dev_put(PCI_Device);

    if (!pmc551list) {
    printk(KERN_NOTICE "pmc551: not detected\n");
    --
    2.1.3


    \
     
     \ /
      Last update: 2014-11-20 14:21    [W:4.019 / U:0.104 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site