lkml.org 
[lkml]   [2014]   [Nov]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH 1/1] [media] platform: Deletion of unnecessary checks before two function calls
    From: Markus Elfring <elfring@users.sourceforge.net>
    Date: Thu, 20 Nov 2014 11:44:20 +0100

    The functions i2c_put_adapter() and release_firmware() test whether their
    argument is NULL and then return immediately. Thus the test around the call
    is not needed.

    This issue was detected by using the Coccinelle software.

    Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    ---
    drivers/media/platform/exynos4-is/fimc-is.c | 6 ++----
    drivers/media/platform/s3c-camif/camif-core.c | 3 +--
    2 files changed, 3 insertions(+), 6 deletions(-)

    diff --git a/drivers/media/platform/exynos4-is/fimc-is.c b/drivers/media/platform/exynos4-is/fimc-is.c
    index 5476dce..a1db27b 100644
    --- a/drivers/media/platform/exynos4-is/fimc-is.c
    +++ b/drivers/media/platform/exynos4-is/fimc-is.c
    @@ -428,8 +428,7 @@ static void fimc_is_load_firmware(const struct firmware *fw, void *context)
    * needed around for copying to the IS working memory every
    * time before the Cortex-A5 is restarted.
    */
    - if (is->fw.f_w)
    - release_firmware(is->fw.f_w);
    + release_firmware(is->fw.f_w);
    is->fw.f_w = fw;
    done:
    mutex_unlock(&is->lock);
    @@ -937,8 +936,7 @@ static int fimc_is_remove(struct platform_device *pdev)
    vb2_dma_contig_cleanup_ctx(is->alloc_ctx);
    fimc_is_put_clocks(is);
    fimc_is_debugfs_remove(is);
    - if (is->fw.f_w)
    - release_firmware(is->fw.f_w);
    + release_firmware(is->fw.f_w);
    fimc_is_free_cpu_memory(is);

    return 0;
    diff --git a/drivers/media/platform/s3c-camif/camif-core.c b/drivers/media/platform/s3c-camif/camif-core.c
    index b385747..3b09b5b 100644
    --- a/drivers/media/platform/s3c-camif/camif-core.c
    +++ b/drivers/media/platform/s3c-camif/camif-core.c
    @@ -256,8 +256,7 @@ static void camif_unregister_sensor(struct camif_dev *camif)
    v4l2_device_unregister_subdev(sd);
    camif->sensor.sd = NULL;
    i2c_unregister_device(client);
    - if (adapter)
    - i2c_put_adapter(adapter);
    + i2c_put_adapter(adapter);
    }

    static int camif_create_media_links(struct camif_dev *camif)
    --
    2.1.3


    \
     
     \ /
      Last update: 2014-11-20 12:21    [W:4.029 / U:0.268 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site