lkml.org 
[lkml]   [2014]   [Nov]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH 1/1] [media] i2c: Deletion of an unnecessary check before the function call "rc_unregister_device"
    From: Markus Elfring <elfring@users.sourceforge.net>
    Date: Thu, 20 Nov 2014 11:13:16 +0100

    The rc_unregister_device() function tests whether its argument is NULL
    and then returns immediately. Thus the test around the call is not needed.

    This issue was detected by using the Coccinelle software.

    Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    ---
    drivers/media/i2c/ir-kbd-i2c.c | 3 +--
    1 file changed, 1 insertion(+), 2 deletions(-)

    diff --git a/drivers/media/i2c/ir-kbd-i2c.c b/drivers/media/i2c/ir-kbd-i2c.c
    index 8311f1a..175a761 100644
    --- a/drivers/media/i2c/ir-kbd-i2c.c
    +++ b/drivers/media/i2c/ir-kbd-i2c.c
    @@ -464,8 +464,7 @@ static int ir_remove(struct i2c_client *client)
    cancel_delayed_work_sync(&ir->work);

    /* unregister device */
    - if (ir->rc)
    - rc_unregister_device(ir->rc);
    + rc_unregister_device(ir->rc);

    /* free memory */
    return 0;
    --
    2.1.3


    \
     
     \ /
      Last update: 2014-11-20 12:01    [W:4.067 / U:1.588 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site